search

drlippman / IMathAS

IMathAS Online Math Assessment
Other
112 stars 99 forks source link

Bug fixes in simplexsolve2() #302

Closed Cash4Programming closed 2 years ago

Cash4Programming commented 2 years ago

Upload the file this time.

drlippman commented 2 years ago

Is there a reason for creating duplicated code for the fraction parsing/reducing instead of using the existing functions? Likewise any reason for duplicating gcd? It's likely having the same function defined twice will trigger an error.

drlippman commented 2 years ago

I'm going to manually merge the simplexsolve2 fix to avoid merging the other changes that seem questionable.

Cash4Programming commented 2 years ago 
The simplex fraction code was created when I was tracking down
  the division errors.  I can switch it back to the fraction one if
  you want.  The idea was that if an error occurs it will occur in
  the simplex code and give the line numbers of where the error
  occurred. At least in theory.
It would be a simple fix.
Do you know how to eliminate commits in my github repository that
  will never be accepted (you have accepted newer version of the
  simplex).  Is there a way to clear/close/delete them?
Thanks,

Mike
On 12/7/2021 9:18 PM, David Lippman
  wrote:

  Is there a reason for creating duplicated code for
    the fraction parsing/reducing instead of using the existing
    functions? Likewise any reason for duplicating gcd? It's likely
    having the same function defined twice will trigger an error.
  —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub, or unsubscribe.
    Triage notifications on the go with GitHub Mobile for iOS or Android.

  [

{ @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/drlippman/IMathAS/pull/302#issuecomment-988507882", "url": "https://github.com/drlippman/IMathAS/pull/302#issuecomment-988507882", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]