search

drlippman / IMathAS

IMathAS Online Math Assessment
Other
113 stars 99 forks source link

Correct File #336

Closed Cash4Programming closed 2 years ago

Cash4Programming commented 2 years ago

This should be the correct file.

drlippman commented 2 years ago

I do not want to be coding in translations for individual languages like this. I don't want to try to adapt the language based on the browser-declared language, especially not on a file-by-file basis. gettext is what we use to handle internationalization, so there's no need to do this; if the server is set to use de as the language, the gettext translation will be used for that language, so there's no need to code translations into the script.

The only reason I was OK the en-GB/en-CA being handled separately is because they were 99% the same language, so probably wouldn't need/want a full gettext translation, plus we have some Canadian users on MOM, so being able to make a small adjustment for a few words was nice.

Cash4Programming commented 2 years ago

OK - I will eliminate the version I have and rollback to the one in your master repository.

On Mon, May 16, 2022 at 11:39 AM David Lippman @.***> wrote:

I do not want to be coding in translations for individual languages like this. I don't want to try to adapt the language based on the browser-declared language, especially not on a file-by-file basis. gettext is what we use to handle internationalization, so there's no need to do this; if the server is set to use de as the language, the gettext translation will be used for that language, so there's no need to code translations into the script.

The only reason I was OK the en-GB/en-CA being handled separately is because they were 99% the same language, so probably wouldn't need/want a full gettext translation, plus we have some Canadian users on MOM, so being able to make a small adjustment for a few words was nice.

— Reply to this email directly, view it on GitHub https://github.com/drlippman/IMathAS/pull/336#issuecomment-1128008229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA37HZWVH4A6BCEXZZDVN7TVKKI4ZANCNFSM5VW7FEKQ . You are receiving this because you authored the thread.Message ID: @.***>