search

drlivingston / kr

Clojure API for RDF and SPARQL - provides consistent access to APIs including Jena and Sesame
56 stars 17 forks source link

forward rule reification ignores non-variable symbols #7

Closed drlivingston closed 10 years ago

drlivingston commented 10 years ago

Non-variable symbols used in forward-rule reification expressions are translated to nil instead of being left alone.

In kr-core/src/main/clojure/edu/ucdenver/ccp/kr/forward_rule.clj lines that look like:

      (apply reify-md5 (map bindings params)))))

need to be changed to:

      (apply reify-md5 (subst-bindings params bindings)))))

and tests need to be written to verify.

If non-variables were used in these expressions where hashing occurred then collisions may have occurred.