drmfinlay
commented
2 years ago Hello Tassilo,
Thank you for this patch. It looks like I either misread the Todoist API reference or didn't change the code for converting labels last year. I think labels might have been a premium feature at that time.
Anyhow, this is better fixed by properly converting the label objects to tags in the relevant todoist2org functions. I'll make the necessary changes in this pull request.
I note also that labels are not currently output according to the item_order attribute. I'll fix this while I'm at it.
Thanks, Dane
On Sun, 12 Dec 2021 04:14:25 -0800 Tassilo Neubauer @.***> wrote:
Join expects items of the type string. See https://docs.python.org/3/library/stdtypes.html#str.join The fix should work as long as all items in the "tags" iterable are either of type string or have the attribute data["name"]. You can view, comment on, or merge this pull request online at:
https://github.com/Danesprite/todoist-org-mode/pull/4
-- Commit Summary --
- Fix join KeyError
- Fix TypeError for tags
-- File Changes --
M todoist2org.py (5)-- Patch Links --
https://github.com/Danesprite/todoist-org-mode/pull/4.patch https://github.com/Danesprite/todoist-org-mode/pull/4.diff
Join expects items of the type string. See https://docs.python.org/3/library/stdtypes.html#str.join The fix should work as long as all items in the "tags" iterable are either of type string or have the attribute data["name"].