search

drmgc / i3ipcpp

MIT License
25 stars 24 forks source link

Ship all available information with the i3 events. #2

Closed mox-mox closed 8 years ago

mox-mox commented 8 years ago

When receiving i3 events, some information, like the "current" and "old" properties of the workspace event are not passed on. Could you please add a way to access the missing properties/information when receiving an event?

drmgc commented 8 years ago

I warn you: it would break backward compatibility

drmgc commented 8 years ago

Please test it, if you can.

mox-mox commented 8 years ago

First of all, big thanks for adding the information. For me, it seems to work with one small exception: I3 will report border = pixel if the setting "new_window pixel" is used. With me, this raises errors for all windows that use this style.

drmgc commented 8 years ago

Create an issue, please

drmgc commented 8 years ago

@mox-mox also, if you getting in border field value, that not expected by i3ipc++, you could recognize it from border, that would equals BorderStyle::UNKNOWN, and border_raw field of container_t, that in the case of BorderStyle::UNKNOWN would contain a value of border field, recived from i3

drmgc commented 8 years ago

@mox-mox also, there is no one word about pixel border style in documentation: 099 There is also few new features, that I can't implemente dut to the fact, that I use Debian 8, so:

i3 version 4.8 (2014-06-15, branch "4.8") © 2009-2014 Michael Stapelberg and contributors