search

drmgc / i3ipcpp

MIT License
25 stars 24 forks source link

Fix for W: Got a unknown "border" property: "pixel". #6

Closed mox-mox closed 8 years ago

mox-mox commented 8 years ago

When setting "new window pixel 1" in the i3config, i3 will send "border" : "pixel" as border style in the tree reply. Example: { "border" : "pixel", "current_border_width" : -1, "deco_rect" : { "height" : 0, "width" : 0, "x" : 0, "y" : 0 }, "floating" : "auto_off", "floating_nodes" : [], "focus" : [], "focused" : false, "fullscreen_mode" : 0, "geometry" : { "height" : 0, "width" : 0, "x" : 0, "y" : 0 }, "id" : 31099360, "last_split_layout" : "splith", "layout" : "dockarea", "name" : "bottomdock", "nodes" : [], "orientation" : "none", "percent" : null, "rect" : { "height" : 0, "width" : 1600, "x" : 0, "y" : 900 }, "scratchpad_state" : "none", "sticky" : false, "swallows" : [ { "dock" : 3, "insert_where" : 2 } ], "type" : "dockarea", "urgent" : false, "window" : null, "window_rect" : { "height" : 0, "width" : 0, "x" : 0, "y" : 0 }, "workspace_layout" : "default" } This pull request adds recognition for this border style. On the other hand, I was not able to receive "1pixel" as border reply. I think the documentation of the IPC interface (interprocess communication) is just outdated there.

drmgc commented 8 years ago

Perhaps, USE_FULL_SIGNALS should not change type of signalevent, but should add signalevent_json. What is someone will need both?

mox-mox commented 8 years ago

No one will need both. Adding the Json to the events was my attempt at adding the information to the i3-events. When you added that information in your code, I removed my attempts in the commit "Did the merge work?" and some leftovers in "Removing remaining modifications from CMakefilelists.txt, ...". That part is removed and not relevant (but I could not find a way to exclude these commits from the pull request).

Now, if you click on the last commit above ("Removing remaining modifications from CMakefilelists.txt, ...".), and then on " You are viewing a subset of the changes. View all changes", you will get to https://github.com/drmgc/i3ipcpp/pull/6/files which shows the changes this pull request should add to your code:

Best regards, mox