search

drmikecrowe / mbfcext

Media Bias Fact Check extension
https://drmikecrowe.github.io/mbfcext/
MIT License
36 stars 7 forks source link

Popup boxes don't close when switching tabs via shortcut #31

Open nerivera opened 2 years ago

nerivera commented 2 years ago

Summary

The popup boxes that appear when you click on the extension icon persist when switching tabs using the keyboard shortcuts (e.g. ctrl+tab). This also includes closing the tab (ctrl/command+W) and opening a new tab (ctrl/command+T). It does not include closing the current window or opening a new window. This happens in both regular and private windows.

Steps to reproduce

  1. Open two arbitrary websites on two different tabs
  2. Click on the extension icon on either site so that the popup box appears
  3. Use a keyboard shortcut to navigate to a different tab, open a new tab, or close the current tab
  4. Note that the popup box remains open

Expected behavior

The popup box should close when switching tabs or should change to match the rating of the tab being switched to.

Device info

macOS Monterey 12.2.1 Firefox 97.0 (64-bit) Media Bias/Fact Check Extension 3.3.0

I did not test this on other browsers or operating systems

drmikecrowe commented 2 years ago

So, I'm not sure this is something I can/should fix. For me, the same functionality exists in:

Seems like this is how Firefox operates

nerivera commented 2 years ago

@drmikecrowe For all of those, it makes sense for the popup box to stay open without changing when switching tabs. Firefox Account and LastPass don't care about the current tab, and Awesome Screenshot only cares once you start taking the screenshot or recording. However, the MBFC popup box is specific to the current tab, so I don't think the same logic applies.

drmikecrowe commented 2 years ago

My point was more this is Firefox specific operation than something I control. In Chromium based browsers, I don't specifically close it when the tab changes, the browser does that. Let me investigate who difficult it will be

nerivera commented 2 years ago

@drmikecrowe You don't have to close the pop-up box. You should just be able to update what it says when the tab changes, if that's easier.