search

drmmr763 / sgo_social_module

Custom s-go consulting social module to handle displaying social icons.
1 stars 0 forks source link

Inline CSS #1

Closed betweenbrain closed 11 years ago

betweenbrain commented 12 years ago

The widths of the default Icon Wrapper CSS and Icon CSS doesn't work too well is Beez, and likely will have issues with most templates.

Personally, I'd remove all inline CSS and opt for easily overridable CSS, but that's just crazy zealous me ;)

Otherwise, I'd remove the widths from the Icon Wrapper CSS to only float:left; and Icon CSS to something like float:left;padding: 0 5px; This will allow is to behave responsively, and fit more designs more easily.

Just a thought.

betweenbrain commented 12 years ago

Oh ya, it works great otherwise. Nice work!

drmmr763 commented 12 years ago

The thought process was that with these CSS styles being a param in the XML, that they can be easily changed per-instance of the module without the need to edit any CSS files. I don't like inline CSS myself, but in this case it's editable in module config.

With that in mind, is there still a benefit / drawback to responsive implementations here?

betweenbrain commented 12 years ago

I can see the benefit of having configurable styles, and the inline CSS accommodates that. No worries mate!

Regarding the CSS itself, I'd always stay away from any fixed widths if you want it to work more easily in a variety of designs. No drawbacks there IMO.

Best,

Matt Thomas Founder betweenbrain http://betweenbrain.com/™ Lead Developer Construct Template Development Frameworkhttp://construct-framework.com/ Phone: 203.632.9322 Twitter: @betweenbrain Github: https://github.com/betweenbrain

On Tue, Jul 10, 2012 at 4:35 PM, Chad Windnagle < reply@reply.github.com

wrote:

The thought process was that with these CSS styles being a param in the XML, that they can be easily changed per-instance of the module without the need to edit any CSS files. I don't like inline CSS myself, but in this case it's editable in module config.

With that in mind, is there still a benefit / drawback to responsive implementations here?

Reply to this email directly or view it on GitHub: https://github.com/drmmr763/sgo_social_module/issues/1#issuecomment-6888095