search

drmohundro / SWXMLHash

Simple XML parsing in Swift
MIT License
1.41k stars 205 forks source link

Fix CDATA Parsing on Linux #175

Closed drmohundro closed 6 years ago

drmohundro commented 6 years ago

It appears that there is a difference between the Linux and Mac implementations of XMLParser - on the Mac side of things, the CDATA content gets returned regardless of if the implementation handles the parser(_:foundCDATA:) method or not; however, in Linux, it doesn't return CDATA in foundCharacters at all.

Fixes #172

codecov-io commented 6 years ago

Codecov Report

Merging #175 into master will increase coverage by 0.75%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   26.38%   27.13%   +0.75%     
==========================================
  Files          13       13              
  Lines        2024     2034      +10     
==========================================
+ Hits          534      552      +18     
+ Misses       1490     1482       -8
Impacted Files Coverage Δ
...ts/SWXMLHashTests/LazyWhiteSpaceParsingTests.swift 0% <ø> (ø) :arrow_up:
Tests/SWXMLHashTests/WhiteSpaceParsingTests.swift 0% <ø> (ø) :arrow_up:
Source/SWXMLHash.swift 76.95% <100%> (+0.86%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e942e2...684c4a4. Read the comment docs.