search

drmuey / p5-File-Copy-Recursive

Perl extension for recursively copying files and directories
5 stars 12 forks source link

Testing relies on UMASK #12

Closed teoric closed 6 years ago

teoric commented 6 years ago

In my shell configuration, I set a UMASK. Installing the module locally, tests complain about the file mode (see reports below). Reinstalling with umask 022, there is no error. In my opinion, it would be better for testing to set UMASK explicitly, so that users can freely chose their UMASK.

(Perl 5.6.21, x86_64-linux-thread-multi, File-Copy-Recursive-0.40).

PERL_DL_NONLAZY=1 "/home/…/perl5/perlbrew/perls/perl-5.26.1/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/00.load.t ............... ok   
t/01.legacy.t ............. 37/? # File [/tmp/u90MagnmCM/what/what] mode is not 0751!

#   Failed test 'DirPerms in pathmk() effects initial new dir'
#   at t/01.legacy.t line 208.
# File [/tmp/u90MagnmCM/what/what/what] mode is not 0751!

#   Failed test 'DirPerms in pathmk() effects subsequent new dir'
#   at t/01.legacy.t line 209.
# File [/tmp/u90MagnmCM/new] mode is not 0751!

#   Failed test 'DirPerms in dircopy() effects dir (new)'
#   at t/01.legacy.t line 215.
# File [/tmp/u90MagnmCM/new/foo] mode is not 0751!

#   Failed test 'DirPerms in dircopy() effects dir (new/foo)'
#   at t/01.legacy.t line 215.
# File [/tmp/u90MagnmCM/new/foo/bar] mode is not 0751!

#   Failed test 'DirPerms in dircopy() effects dir (new/foo/bar)'
#   at t/01.legacy.t line 215.
# File [/tmp/u90MagnmCM/new/foo/baz] mode is not 0751!

#   Failed test 'DirPerms in dircopy() effects dir (new/foo/baz)'
#   at t/01.legacy.t line 215.
# File [/tmp/u90MagnmCM/new/foo/bar/wop] mode is not 0751!

#   Failed test 'DirPerms in dircopy() effects dir (new/foo/bar/wop)'
#   at t/01.legacy.t line 215.
# Looks like you failed 7 tests of 109.
t/01.legacy.t ............. Dubious, test returned 7 (wstat 1792, 0x700)
Failed 7/109 subtests 
t/02.legacy-symtogsafe.t .. ok     
t/03.github-issue-5.t ..... ok   
t/04.readonly-dir.t ....... ok
drmuey commented 6 years ago

Thanks, this should be fixed in v0.41:

a52b355 Issue #12 and rt 124166 - set umask for reliability (thanks teoric and ether)