0.43 tests under strawberry perl

[zdm]

Checking if you have Test::Fatal 0 ... Yes (0.014)
Checking if you have Path::Tiny 0 ... Yes (0.104)
Building and testing File-Copy-Recursive-0.43 ... cp lib/File/Copy/Recursive.pm blib\lib\File\Copy\Recursive.pm
"D:\devel\perl32\perl\bin\perl.exe" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib\lib', 'blib\arch')" t/*.t
t/00.load.t ............... ok
t/01.legacy.t ............. ok
t/02.legacy-symtogsafe.t .. skipped: symlink tests not applicable on systems w/ out symlink support (MSWin32)
t/03.github-issue-5.t ..... ok
t/04.readonly-dir.t ....... skipped: test uses chmod which may or may not do what we want here, patches welcome!
t/05.legacy-pathmk_unc.t .. # Testing legacy File::Copy::Recursive::pathmk() 0.43
t/05.legacy-pathmk_unc.t .. 1/?
#   Failed test 'pathmk regular path'
#   at t/05.legacy-pathmk_unc.t line 60.
# Comparing $data as a Bag
# Missing: 'C:\Users\zdm\AppData\Local\Temp\XuNix3n9Lx/foo', 'C:\Users\zdm\AppData\Local\Temp\XuNix3n9Lx/foo/bar', 'C:\Users\zdm\AppData\Local\Temp\XuNix3n9Lx/foo/bar/baz'
# Extra: 'C:/Users/zdm/AppData/Local/Temp/XuNix3n9Lx/foo', 'C:/Users/zdm/AppData/Local/Temp/XuNix3n9Lx/foo/bar', 'C:/Users/zdm/AppData/Local/Temp/XuNix3n9Lx/foo/bar/baz'

#   Failed test 'pathmk unc'
#   at t/05.legacy-pathmk_unc.t line 78.
#     Structures begin differing at:
#          $got->[0] = 'C:/Users/zdm/AppData/Local/Temp/XuNix3n9Lx/foo'
#     $expected->[0] = 'C:\Users\zdm\AppData\Local\Temp\XuNix3n9Lx'
# Looks like you failed 2 tests of 6.
t/05.legacy-pathmk_unc.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/6 subtests

Test Summary Report
-------------------
t/05.legacy-pathmk_unc.t (Wstat: 512 Tests: 6 Failed: 2)
  Failed tests:  4, 6
  Non-zero exit status: 2
Files=6, Tests=103,  3 wallclock secs ( 0.06 usr +  0.03 sys =  0.09 CPU)
Result: FAIL
Failed 1/6 test programs. 2/103 subtests failed.
gmake: *** [Makefile:882: test_dynamic] Error 2
FAIL
! Installing D/DM/DMUEY/File-Copy-Recursive-0.43.tar.gz failed. See C:\Users\zdm\AppData\Local\Temp\.cpanm\work\1524345452.15336\build.log for details. Retry with --force to force install it.

[drmuey]

Thanks @zdm looks like @LouisStrous‘s test from PR #4 is doing the trick :)

I’ll revisit #4’s fix that was left out as apparently it wasn’t already like that after all.

[drmuey]

Does that UNC test pass under v0.41 or v0.42 ?

[zdm]

yes, it works under 0.42

[drmuey]

@zdm thanks for verifying that for me! can you verify if t/05.legacy-pathmk_unc.t passes in the issue-18 branch (specifically 208fecb)?

[zdm]

Hey. No, not works.

t/05.legacy-pathmk_unc.t .. 1/?
#   Failed test 'pathmk regular path'
#   at t/05.legacy-pathmk_unc.t line 60.
# Comparing $data as a Bag
# Missing: 'C:\Users\zdm\AppData\Local\Temp\FqEk6Cz_J7/foo', 'C:\Users\zdm\AppData\Local\Temp\FqEk6Cz_J7/foo/bar', 'C:\Users\zdm\AppData\Local\Temp\FqEk6Cz_J7/foo/bar/baz'
# Extra: 'C:/Users/zdm/AppData/Local/Temp/FqEk6Cz_J7/foo', 'C:/Users/zdm/AppData/Local/Temp/FqEk6Cz_J7/foo/bar', 'C:/Users/zdm/AppData/Local/Temp/FqEk6Cz_J7/foo/bar/baz'

#   Failed test 'pathmk unc'
#   at t/05.legacy-pathmk_unc.t line 78.
#     Structures begin differing at:
#          $got->[0] = 'C:/Users/zdm/AppData/Local/Temp/FqEk6Cz_J7/foo'
#     $expected->[0] = 'C:\Users\zdm\AppData\Local\Temp\FqEk6Cz_J7'
# Looks like you failed 2 tests of 6.
t/05.legacy-pathmk_unc.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/6 subtests

[drmuey]

@zdm thanks again, I believe 5e7638b will do the trick, it simplifies the test.

Let me know and I'll fix it or publish it ;)

[zdm]

I will test a bit later.

On 24.04.2018 15:51, drmuey wrote:

@zdm https://github.com/zdm thanks again, I believe 5e7638b https://github.com/drmuey/p5-File-Copy-Recursive/commit/5e7638b82fc56cd3aefa84c16f33c4f63cdaadfd will do the trick, it simplifies the test

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/drmuey/p5-File-Copy-Recursive/issues/18#issuecomment-383918583, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-mSAIrrhCoomPfN5l0eVBR_-ebs8cZks5trx_dgaJpZM4Tenz2.

[drmuey]

@zdm sounds great, really appreciate your help ;)

[zdm]

I already tested, it works. ;-)

On 24.04.2018 16:02, drmuey wrote:

@zdm https://github.com/zdm sounds great, really appreciate your help ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/drmuey/p5-File-Copy-Recursive/issues/18#issuecomment-383921845, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-mSC5ecqpLcebbiN1qQScTO7H459r9ks5tryJcgaJpZM4Tenz2.

[drmuey]

@zdm awesome, that is great news. will do the release soon, again very much appreciated!!

[drmuey]

Just uploaded v0.44 to CPAN, should show up anytime. Thanks!

[zdm]

Thank you!

On 24.04.2018 16:23, drmuey wrote:

Closed #18 https://github.com/drmuey/p5-File-Copy-Recursive/issues/18.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/drmuey/p5-File-Copy-Recursive/issues/18#event-1591585688, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-mSGlE62i_hbgnXhSXkb91ibQyBbChks5trydogaJpZM4Tenz2.