search

drmuey / p5-File-Copy-Recursive

Perl extension for recursively copying files and directories
5 stars 12 forks source link

Makefile.PL's `TEST_REQUIRES` requires a modern ExtUtils::MakeMaker #33

Closed DrHyde closed 3 years ago

DrHyde commented 3 years ago

File::Copy::Recursive, and anything that depends on it, won't build on a fresh install of some old versions of perl, because the EU::MM bundled with them doesn't understand TEST_REQUIRES and so the dependencies on things like Test::File and Test::Warnings won't be spotted. In particular this affects Test::File::ShareDir, which affects DateTime::Locale, which affects DateTime, which affects, well, just about everything.

The fix is to either merge TEST_REQUIRES into PREREQ_PM or, I think, declare the requirement for a modern EU::MM in META.json.

To see this bug in action, search for Unpacking File-Copy-Recursive-0.45.tar.gz here and watch as it fails to build

tomhukins commented 3 years ago

This looks like a duplicate of #27

DrHyde commented 3 years ago

You're right, it is. Naughty me!