drnic / github-tmbundle

TextMate bundle for working with GitHub
229 stars 37 forks source link

Incorrect method call (Gist.send instead of Gist.write) #2

Open e1senh0rn opened 15 years ago

e1senh0rn commented 15 years ago

What I did: Made "Gist from selection" in TextMate with latest (37fe3f299283b5c493bf71911d951840f0f2474a) version of bundle.

What I've expected: Pasting selected text/all text if none selected on github.

What I got: Error saying "send: not a symbol (false). TypeError".

How to fix: In the latest commit (37fe3f299283b5c493bf71911d951840f0f2474a) Gist.send was renamed to Gist.write in Support/lib/gist.rb, but this change was not applied to places, where this method was actually called (Support/bin/create_gist_from_selection.rb, Support/bin/send_multifile_gist.rb).

It is also partially fixed in joshua's fork (http://github.com/joshua/github-tmbundle/commit/3eeeeaee95124b19190d9903ce9935d8e7ca3286).