search

drobilla / serd

A lightweight C library for RDF syntax
https://gitlab.com/drobilla/serd
ISC License
86 stars 15 forks source link

Fix autowaf gitmodules path #25

Closed nick87720z closed 4 years ago

nick87720z commented 5 years ago

The personal hosting (git.drobilla) doesn't accept path without ".git" ending. Github/gitlab do. However, all 3 do well when ending is used.

Unfortunally, gentoo git-based ebuilds can't use gitmodules patch, because there is no way to split primary and modules fetching. So, such change looks more urgent to submit, that anything else.

P.S. Looks like it is not matter of ".git" suffix, but rather ability to support only one or with optional ext. Github/gitlab allow both with ".git" and without it. As for git.drobilla.org, I compared it with almost similar git.xfce.org, which look like having same engine. Difference is that xfce hosting has not ".git" at the end, but as result, it will not work when this URI ending presents.

P.P.S. This case with autowaf path seems to be way harder. It's clone path has no ".git", thus it is expected to work without it, but it doesn't. Is it bug?..

drobilla commented 4 years ago

I am probably going to decommission that git server entirely, but seems reasonable enough anyway, thanks. 3f74acb3

rdewaele commented 4 years ago

Is there a specific reason this path is relative? When I forked this repository to make a PR I noticed git tried to fetch the non-existing autowaf repository in my account. ;-)

drobilla commented 4 years ago

Sigh.

It needs to be relative because serd is not only hosted on Github (which isn't even the primary). I suppose I can make it ../../drobilla/autowaf.git