search

drodil / backstage-plugin-qeta

Backstage.io plugin for Q&A
https://www.npmjs.com/package/@drodil/backstage-plugin-qeta
MIT License
84 stars 27 forks source link

Add s3 as storage backend #131

Closed ajuste closed 6 months ago

ajuste commented 6 months ago

How it looks on the editor:

image

How it looks after posted:

image
ajuste commented 6 months ago

@drodil, thanks for the quick feedback; I changed the config strings to be required; instead of using config.getOptionalString, I'm using config.GetString, which throws an error. Let me know if this is enough or you want me to throw another Error.

drodil commented 6 months ago

Thanks. Actually the secret and access keys can be optional. What comes to bucket, it should be optional in the config; if the user is using for example database to store images, he should not need to set the bucket value in the config. So only option is to throw the error yourself.

Does this make sense? 😄

drodil commented 6 months ago

I did some refactoring in #133, will merge that and close this one. Thanks again for the contribution!