search

drodil / backstage-plugin-toolbox

Most commonly used developer tools within Backstage
MIT License
47 stars 25 forks source link

Rich Text to Markdown converter doesn't work (anymore) #65

Open brianphillips opened 1 year ago

brianphillips commented 1 year ago

I recently submitted a PR that was merged (#58) but it appears that the contents of the change were almost entirely ripped out in a subsequent commit (see here). I'm wondering if this was inadvertant (probably?) or if I put things back together, if there's something I need to take into account to avoid breaking something else or from having someone undo the work I did.

Just wanted to check before I reverted what was done to that specific tool.

Thanks!

drodil commented 12 months ago

Hi,

Hmm, yes it might be that it broke, though I tried to go through the functionalities. I was refactoring the tools adding the new download/upload file functionality and also to use the default editor wherever possible. Also I added the preview for the markdown content. What exactly is not working with the tool anymore? At least I can still convert HTML to MD without issues: image

brianphillips commented 12 months ago

Yeah, the purpose of the tool I added was to convert formatted text (rich text) that a user might copy from a non-HTML document (i.e. a Google Doc) into Markdown. It was intended to be separate and distinct from converting HTML to Markdown due to the custom integration with the clipboard. By default, if you were to just copy/paste from a Google Doc into a regular <textarea> (like the default editor), the default "paste" behavior is to just paste the plain text version and all the formatting is lost. The implemention of the "Rich Text to Markdown" tool integrated with the clipboard such that it has access to the formatted content (which is actually HTML, to be fair) and then converting that to Markdown for the output. In this case, I'm not sure the "upload" functionality is relevant but the download functionality perhaps is.

I'm happy to create another PR for you to consider that re-adds this functionality as I find it useful.

drodil commented 12 months ago

Hm, ok. Do you think we could somehow modify the clipboard function from default editor to paste the stuff with formatting? The functionality was a bit weird for me as there was really no input visible but that explains it.

brianphillips commented 12 months ago

Good idea, I will see if an option can be passed in to the default editor to modify the "paste" button (or perhaps to ad a "Paste with formatting" button?) so that not so much needs to be customized for this specific tool. Thanks

ppiwow-apay commented 4 months ago

any news on that? seems to be really useful tool, specially when i want to convert docs to adr/tech docs, as on collaboration docs are pretty usefull