search

drodil / backstage-plugin-toolbox

Most commonly used developer tools within Backstage
MIT License
46 stars 25 forks source link

Migrate toolbox to mui v5 #90

Closed JGoggers closed 7 months ago

JGoggers commented 7 months ago

This MR migrates the tool to mui v5. The toolbox will look a little different in terms of styling here and there.

I tried to look through everything in both light and dark modes to make sure everything is in order. I could've missed some things. The changes also use some colours like #E0E0E0 that I couldn't pick up from the theme. It would be nice if you could find alternatives to hardcoded colours.

drodil commented 7 months ago

Looks promising, thanks for this! Can't wait to get this merged but take your time 🤗

JGoggers commented 7 months ago

@drodil could I have a review please :)

drodil commented 7 months ago

Thanks, looks good! Could you squash the commits a bit? These don't really follow conventional commit messages and there's a lot of WIP commits.

JGoggers commented 7 months ago

@drodil took a while but how do you feel about this?

drodil commented 7 months ago

Thanks a lot! I will take a closer look tomorrow 👌

drodil commented 7 months ago

Thanks once again! If you want to contribute more, I have another plugin with issue to update MUI to v5 as well: https://github.com/drodil/backstage-plugin-qeta/issues/143

No pressure but if you want, I am up for all contributions, thanks!

JGoggers commented 7 months ago

Thanks for the offer! However, I can't contribute to this plugin at the moment 😄