search

drodil / video_auto_pause

Chrome extension to automatically pause/continue video on tab focus changes
MIT License
32 stars 14 forks source link

Feature Request/ Improvement: Don't auto resume if user paused with space bar or click. #4

Open Krinjon opened 2 years ago

Krinjon commented 2 years ago

If you know potplayer auto resume feature it would be easier to explain. Pot player has the perfect autoresume autopause functions anywhere. So in pot player if you pause using space bar and get out of window and come back if does not resume cause it assumes you wanted keep it pause. Video should not auto resume all the time. There should be some way to remember if the user paused the video , if yes dont auto resume let the user resume. And if user auto paused by moveing away from the video only then auto resume.

zcw1030 commented 1 year ago

same here, this would be a very nice feature. thx

Krinjon commented 1 year ago

@zcw1030 do you have auto resume every 1 minute problem? Press space bar to pause then dont do anything for 60 seconds and it auto resumes. Don't move around the cursor. Also auto resumes when changing windows with alt tab in a different desktop (windows 10 11 multi desktop), after leaving it paused. Though does not happen every time , keep trying some times it happens.. Do you have these issues. Cause i dont know if its only my machine..??

zcw1030 commented 1 year ago

@Krinjon hi, i dont have the two issues you mentioned.

but, the video wont auto pause when chrome window lose focus. it only auto pause if chrome is minimized or i change to another viutual desktop. do you have this "not auto pause" issue?

Krinjon commented 1 year ago

@Krinjon hi, i dont have the two issues you mentioned.

but, the video wont auto pause when chrome window lose focus. it only auto pause if chrome is minimized or i change to another viutual desktop. do you have this "not auto pause" issue?

No it auto pauses for me both ways. Did you check the ckeckboxes ?

zcw1030 commented 1 year ago

@Krinjon yes, i check the checkboxes.

do you auto pause in this scenario, two window side by side.

when chrome (left window) lose focus, then auto pause.

image

drodil commented 1 year ago

Hi, Any chance you could reproduce the issue with the latest version and with video capture? I cannot reproduce this myself for some reason.

For the feature request: yes, it makes sense that if you pause the video manually (with spacebar or clicking the pause button) it would not autoresume. I had this in mind some time ago but then life happened and forgot. Let me see if I have time to dig into this. Also if you have coding skills, contributions are more than welcome :)

zcw1030 commented 1 year ago

@drodil https://youtu.be/UsLYhBVfHHk

hi, plz check the video above.

when i focus on window right, the "auto pause when window unfocus" not working.

thx for your help!