droe / sslsplit

Transparent SSL/TLS interception
https://www.roe.ch/SSLsplit
BSD 2-Clause "Simplified" License
1.75k stars 329 forks source link

Log connection-related errors to content and connect logs #134

Open droe opened 8 years ago

droe commented 8 years ago

When connection-related errors happen, they should be logged to the content and/or connect logs in some meaningful way. For -S possibly into a separate file with similar filename, for -L possibly inline with a new logfile syntax, for -l as a failed connection with reasons given. This needs some thinking about how to do it right.

Implementation is related to #132 (add connection-IDs to all logging related to specific connections).

Requested by @CyberSolid in #131.

youngdaniel345 commented 5 years ago

I have been using a version of SSLSplit that my team modified in another project for some time now, and I would be interested in trying to solve this issue along with issue #132 . Before I get too far into the weeds is there anything specifically you want to be included in that solution or would you have any recommendation of where to start?

sonertari commented 5 years ago

We haven't talked about this with Daniel, so I don't know what he has in mind exactly. But I use connection ids and file descriptors to track connections among connection logs and very verbose debug logs produced by my SSLproxy project (which is based on SSLsplit). This solution was helpful for me to trace certain types of issues in many cases. (In SSLproxy, connection handling treads keep track of the connections assigned to them, and time them out if they are idle longer than the expiration period option.) I would suggest that you look at especially the current develop branch of SSLproxy.

youngdaniel345 commented 5 years ago

Great, thank you.