search

droe / sslsplit

Transparent SSL/TLS interception
https://www.roe.ch/SSLsplit
BSD 2-Clause "Simplified" License
1.73k stars 327 forks source link

Write PCAPs without using libnet #235

Closed droe closed 5 years ago

droe commented 5 years ago

Implements #234.

droe commented 5 years ago

Btw I plan on removing the last dependencies on libnet for PCAP writing in later commits, after having finalized packet crafting. Dependencies include the PRNG and conversion of address strings to internal representation.

droe commented 5 years ago

Good catches, thanks! Your fix for 45b42eb was incomplete; I've now cleaned up our seq/ack handling by removing the error-prone and inefficient separate tracking of ack numbers. The FIN handshake should now produce correct results regardless which direction we initiate the first FIN. I will merge this now.