search

drogga / TextWarrior

Other
0 stars 0 forks source link

to @gzsombor regarding SkyTube #9

Open drogga opened 2 years ago

drogga commented 2 years ago

@gzsombor Can you enable the Issues and/or Discussion in your fork of SkyTube ?, because I intend to start using it and I want to report directly to you if there's something wrong, instead in the main repo, since it's behind, your's ahead.

I have to be honest, first impressions - not good, I don't like it at all, I hope that you are not planing to apply those layout/UI & Player changes to the main/original repo (even tho I understand that it's still not polished and in early stage), the only thing I liked was the speed transparent dialog, that's it, but not the fact that it doesn't go beyond x2.0x !

Let me know when you see this, so I can delete it, because I already commented in the repo's issue with a more important observations than those.

drogga commented 1 year ago

@gzsombor Did you read this^ ?

gzsombor commented 1 year ago

I see, interesting way to send messages !

My repo is just a dumping ground for a lot of unfinished, or half thought out implementations, with known bugs - or limitations. The material based theming looks interestingly, unfortunately I've never found the perfect parameter combination, which would made the tabs good looking, but at the same time, also similar to the current look and feel. Even though, the floating, and animated subscribe button looks great, IMHO :) The new player look is just using the stock UI from Exoplayer, and I enjoy that it has subtitles support out of the box, but it uses submenus, which is not that touch friendly, I think. I haven't found out the perfect combination how to create the minimal customization, without code repetition, etc...

drogga commented 1 year ago

the floating, and animated subscribe button looks great, IMHO

This is one of the things I didn't liked at all, because it gets in the way and it's distracting, let's focus on simplicity, instead of visuals and watching videos, instead of subscribing. Keep in mind that I tested the latest Actions build at the time, which was almost a year ago and I don't remember that much...

Edit: Please reply with whatever when you see this, so I know that you've read it, since the react emojis doesn't seem to be available on mobile.