search

drogga / cromite

Cromite a Bromite fork with ad blocking and privacy enhancements; take back your browser!
https://www.cromite.org/
GNU General Public License v3.0
0 stars 0 forks source link

To @uazo #1

Open drogga opened 3 days ago

drogga commented 3 days ago

@uazo, please check the 3 branches (until now) I've created here and let me know if you like the corrections before I go with the PRs. BTW - is it OK if I don't include the default PR template, as the edits I've done are kind of basic and unrelated to the lines in the template, except maybe some of the following: There are no other open Pull Requests for the same update/change Patch description contains explanation of changes No unnecessary whitespace or unrelated changes

If all well, I would like to address a few more things, like the workflow files for example, because the Actions report: The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2 The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2

Thank You in advance.

Keep in mind that I'm editing from a browser, so I'm not sure if I can force push or whatever if necessary as some options might not be available here and I'm not very familiar with how these things work.

drogga commented 3 days ago

Off-topic: This https://github.com/uazo/cromite/issues/1460 should IMO be closed as not planned, instead of as completed, because it's not and the related components (Translate activity) should be removed from the Android builds, because last time I checked there were some that are not necessary for Cromite as their code was removed or the feature disabled, what do you think ?

drogga commented 2 days ago

@uazo Do I have a green light creating the 3 PRs ?

drogga commented 1 day ago

Hey @SkewedZeppelin I apologize in advance for the ping/mention, but it seems like uazo doesn't bother to check his notifications (or reply, but why wouldn't he) and you've mentioned that you emailed him in a now closed ticket in Cromite's repo, can you please share his E-Mail address here ?, because I'm unable to find any and he mentions multiple times in various issues that he doesn't have one or social media, which is hard to believe, but whatever, or pls. at least tell me where and how you found it. Thank You in advance.

I don't want to create PRs in vain, just to be closed, because they stay on record and can't be deleted, not that the owners would want to, even if it was possible/easy.