search

drogonframework / drogon

Drogon: A C++14/17/20 based HTTP web application framework running on Linux/macOS/Unix/Windows
MIT License
11.57k stars 1.12k forks source link

Support for Netpbm MIME types #1004

Closed engineerjames closed 6 months ago

engineerjames commented 3 years ago

Netpbm contains the following file types: The portable pixmap format (PPM), the portable graymap format (PGM) and the portable bitmap format (PBM). I believe drogon could also be extended to support these additional media types without any adverse effects (I would be happy to implement it myself with your blessing 😄 ).

While these content types are not registered with the IANA, I have a use case for them, and would love for them to be supported natively. I know the CT_CUSTOM content enumeration also exists which I could potentially use if there is a hesitancy to support these additional media types.

Conceptually for me it would be much cleaner to rely on the content type solely (vs. additional information in the response body for example).

What do you all think?

an-tao commented 3 years ago

@engineerjames Thank you very much for your feedback, if you can make a PR for this, I would be very grateful.

rbugajewski commented 3 years ago

Thanks for your feedback. If this will be a zero-cost addition to Drogon, then I think it’s OK to have this as part of the main repository (I don’t know what would speak against it), otherwise I would welcome this as a plugin (if possible at all), because of the relative scarcity of these image formats.

Your PRs are welcome ☺️