drogozhang / LED

Source code of paper 'LED: Lexicon-Enlightened Dense Retriever for Large-Scale Retrieval' (WWW 2023)
22 stars 1 forks source link

Question about the loss function in your paper #2

Open liulizuel opened 1 year ago

liulizuel commented 1 year ago

In your paper, the equation (3) and (8) for loss function read, 𝑝 ∈ {𝑝+ } ∩ N, or 𝑝 ∈ {𝑝+ } ∩ N^mix I don't know why you use intersection instead of union. Each batch in your loss function consists of positive passages and negative passages. So I think it confuses me when you use '∩' to represent intersection here.

drogozhang commented 1 year ago

Thank you so much for the great catch! You are 100% correct and I will fix these typos in our next version.

Best, Kai

liulizuel commented 1 year ago

Thank you for your timely response!