search

drogue-iot / drogue-cloud

Cloud Native IoT
https://drogue.io
Apache License 2.0
113 stars 30 forks source link

Resolve clippy pedantry #215

Closed jcrossley3 closed 2 years ago

jcrossley3 commented 2 years ago

Reducing some noise in the build output... let's see if I broke anything important!

ctron commented 2 years ago

That is awesome! I am bit concerned of dropping the dependency on actix-http. What happened in the past was, that they did release a new beta version, which was not compatible anymore with the beta version of actix-web and so the build failed. Adding an explicit, pinned version solved this issue.

jcrossley3 commented 2 years ago

That is awesome! I am bit concerned of dropping the dependency on actix-http. What happened in the past was, that they did release a new beta version, which was not compatible anymore with the beta version of actix-web and so the build failed. Adding an explicit, pinned version solved this issue.

As long as we're pinning actix-web to a specific beta version, won't its transitive deps, e.g. actix-http be pinned, too? I'm mostly just trying to reduce the surface area of things we need to change each time we update actix-web. Seems weird to have to pin its deps if we're already pinning it. (apologies if i'm misunderstanding)

ctron commented 2 years ago

To my understanding, no. It only pins the dependency to the directly referenced one. For the reference dependency, normal resolution rules apply.

As actix-web references actix-http = "3.0.0-beta.18", this is a non-pinned version and may be upgraded: https://github.com/actix/actix-web/blob/master/Cargo.toml#L80

jcrossley3 commented 2 years ago

/test

drogue-bot commented 2 years ago

Aye, aye, captain! … Triggered System Test worklow!

drogue-bot commented 2 years ago
Total Passed Failed Ignored Filtered Duration
✅ 147 147 0 0 0 32m 31s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/warnings

Commit: 0d757f39b2eef189c5c4381246824c1723f6e1dd
Author: Jim Crossley <jim@crossleys.org>
Date: Fri, 14 Jan 2022 22:32:17 +0500

    Address workspace members' clippy warnings

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/1708864011

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/01/17/test-run-1708864011.html

jcrossley3 commented 2 years ago

/test

drogue-bot commented 2 years ago

Aye, aye, captain! … Triggered System Test worklow!

drogue-bot commented 2 years ago
Total Passed Failed Ignored Filtered Duration
✅ 147 147 0 0 0 31m 31s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/warnings

Commit: 3d3ea773844fc3877e2adb8a5bc1e50d4081bf6e
Author: Jim Crossley <jim@crossleys.org>
Date: Mon, 17 Jan 2022 23:07:40 +0500

    Address workspace members' clippy warnings

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/1709641028

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/01/17/test-run-1709641028.html