search

drogue-iot / drogue-cloud

Cloud Native IoT
https://drogue.io
Apache License 2.0
114 stars 30 forks source link

fix: align generation field with k8s api #279

Closed ctron closed 2 years ago

ctron commented 2 years ago

This change only incremenets the generation field when a change of spec section has occurred. Internally there is a revision field, which increments with every change. However, that is not exposed, as the resourceVersion field should be used for detecting any change. While the generation field is intended to track changes of the specification.

This fixes the "obverved generation" never being equal to the "generation", as the status section update again increments the generation field.

ctron commented 2 years ago

/test

drogue-bot commented 2 years ago

Aye, aye, captain! … Triggered System Test worklow!

drogue-bot commented 2 years ago
Total Passed Failed Ignored Filtered Duration
❌ 147 146 1 0 0 38m 56s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/feature/revgen_1

Commit: 1ee6bda37163b52ef83ab99d4ee4b7ca6458350c
Author: Jens Reimann <jreimann@redhat.com>
Date: Wed, 11 May 2022 13:12:38 -0200

    fix: align generation field with k8s api

    This change only incremenets the generation field when
    a change of spec section has occurred. Internally there
    is a revision field, which increments with every change.
    However, that is not exposed, as the resourceVersion field
    should be used for detecting any change. While the
    generation field is intended to track changes of the
    specification.

    This fixes the "obverved generation" never being equal
    to the "generation", as the status section update again
    increments the generation field.

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/2308008604

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/05/11/test-run-2308008604.html