Use common HTTP server creation logic

drogue-iot / drogue-cloud

Cloud Native IoT

https://drogue.io

Apache License 2.0

113 stars 30 forks source link

Use common HTTP server creation logic #299

Closed ctron closed 2 years ago

ctron commented 2 years ago

The removes the gazillion ways we had to create an HttpServer instance. All slightly different, all lacking an option here and there. Now all use the same logic.

Remaining tasks:

[x] In server, create a single, combined API endpoint
[x] Change Helm charts to use new configuration, and create a macro there too
[x] Allow serving the frontend too

ctron commented 2 years ago

True, that isn't solved yet but this PR. A little more work is required.

ctron commented 2 years ago

@lulf next version, this time with the composite API, updated helm charts, and an option to serve the UI folder too

ctron commented 2 years ago

/test

drogue-bot commented 2 years ago

Aye, aye, captain! … Triggered System Test worklow!

drogue-bot commented 2 years ago

Test run finished, but did not create a test report: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/2596632446

ctron commented 2 years ago

/test

drogue-bot commented 2 years ago

Aye, aye, captain! … Triggered System Test worklow!

drogue-bot commented 2 years ago

	Total	Passed	Failed	Ignored	Filtered	Duration
❌	148	2	146	0	0	1h 26m 14s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/feature/align_http_server_1

Commit: 1f651c0abbf457100e3f0080ed0ea09380dbf7c7
Author: Jens Reimann <jreimann@redhat.com>
Date: Fri, 01 Jul 2022 11:18:15 -0200

    build: try to clean up optional imports and features

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/2596890654

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/07/01/test-run-2596890654.html

ctron commented 2 years ago

/test

drogue-bot commented 2 years ago

Aye, aye, captain! … Triggered System Test worklow!

drogue-bot commented 2 years ago

	Total	Passed	Failed	Ignored	Filtered	Duration
✅	148	148	0	0	0	53m 59s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/feature/align_http_server_1

Commit: cd60766a67b7a413ee9ece31470e0ad69126498c
Author: Jens Reimann <jreimann@redhat.com>
Date: Fri, 01 Jul 2022 14:07:59 -0200

    chore: update charts

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/2597847181

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/07/01/test-run-2597847181.html