search

drogue-iot / drogue-cloud

Cloud Native IoT
https://drogue.io
Apache License 2.0
113 stars 30 forks source link

[server] update to clap v3 and other improvements #313

Closed jbtrystram closed 2 years ago

jbtrystram commented 2 years ago

add a couple of missing args and fixes #310

So instead of crashing on an unwrap now clap will display an error : 

target/debug/drogue-cloud-server run --enable-all  --enable-console-frontend 
error: The following required arguments were not provided:
    --ui-dist <PATH>

USAGE:
    drogue-cloud-server run --ui-dist <PATH> --enable-all --enable-console-frontend

I still think that --enable console-frontend can be merged with --ui-dist but I don't want to break too much things

ctron commented 2 years ago

IIRC the console frontend will be enabled if the ui-dist argument and the --enable-all flag is used. Which is also used by the container image.

Does that still work?

jbtrystram commented 2 years ago

IIRC the console frontend will be enabled if the ui-dist argument and the --enable-all flag is used. Which is also used by the container image.

Does that still work?

yes