Console: Allow adding description when creating access keys

[jbtrystram]

When clicking on the create button:

Then a confirmation modal :

[jbtrystram]

@ctron I think that requires some change in the integration tests ?

[ctron]

@ctron I think that requires some change in the integration tests ?

Yea, that could be.

[ctron]

This is great! There are just two small things I think we could improve:

Add a bit of padding between the copy & paste field and the top/bottom text.

Second, I am unsure about the yellow button. The outcome is "success", but the button indicates "warning", but doesn't highlight the "why".

Here is an example from Azure:

I also saw (can't find it now) a checkbox (with "I copied the token and know that I can't get it back") plus disabling the close button as long as the checkbox is not ticked.

[jbtrystram]

I also saw (can't find it now) a checkbox (with "I copied the token and know that I can't get it back") plus disabling the close button as long as the checkbox is not ticked.

I don't like this, it feels like something frustrating that i would not really read :D The yellow box with a warning that you showed is good imho, it attract the eyes and get the the point across.

[ctron]

IIRC Patternfly had an "inline" variant for this: https://www.patternfly.org/v4/components/alert/#inline-types

Not sure we support it yet.

[jbtrystram]

@ctron here is the redesigned modal :

Thanks for the feedback !