search

drogue-iot / drogue-cloud

Cloud Native IoT
https://drogue.io
Apache License 2.0
113 stars 30 forks source link

chore: clarify development k8s version #377

Closed andrusha closed 1 year ago

andrusha commented 1 year ago

knative-serving 1.7.2 helm chart depends on the HorizontalPodAutoscaler beta version, which triggers following error on k8s >1.25 as it went out of beta since then:

resource mapping not found for name: "activator" namespace: "knative-serving" from "https://github.com/knative/serving/releases/download/knative-v1.7.2/serving-core.yaml": no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta2"
ensure CRDs are installed first
resource mapping not found for name: "webhook" namespace: "knative-serving" from "https://github.com/knative/serving/releases/download/knative-v1.7.2/serving-core.yaml": no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta2"

https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/

ctron commented 1 year ago

It might make sense to do another round of dependency upgrades in general. But for now, I think it's good to merge this.

andrusha commented 1 year ago

Thanks, I have no access to merge, so if you could it would be appreciated.

Looks like related issue https://github.com/knative/serving/issues/13519, which was fixed in 1.8.2 milestone, so it is a minor bump https://github.com/drogue-iot/drogue-cloud/blob/main/scripts/cmd/__knative.sh#L5, but not sure how to test it properly myself, would appreciate guidance.