droidchef / android-lockpattern

Automatically exported from code.google.com/p/android-lockpattern
Apache License 2.0
0 stars 0 forks source link

Cyanogen Configurable 6x6 dot model pattern #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hello,

The Cyanogen version permit to choose the number of dot in the pattern model
4x4
5x5
6x6

See 
https://github.com/CyanogenMod/android_frameworks_base/blob/cm-10.2/policy/src/c
om/android/internal/policy/impl/keyguard/KeyguardPatternView.java 

mLockPatternView.setLockPatternSize

This feature is very interesting for increase the security of the pattern model.

Original issue reported on code.google.com by jmori...@gmail.com on 15 Nov 2013 at 9:50

GoogleCodeExporter commented 9 years ago
Hi,

Currently you can open LockPatternView and change the value of MATRIX_WIDTH to 
the one you prefer. Unfortunately, because the library uses fixed size icons 
(the circle, the dot...), so if you increase the MATRIX_WIDTH, there could be 
not enough space for them all. We can solve that by drawing the objects 
(circle, dots...) manually. But none of us (in HBA) is good at graphics  :-(

Also, please open `res/values/dimens.xml` and change `alp_lockpatternview_size` 
respectively.

I hope this could help a little  :-)

Original comment by haibison...@gmail.com on 15 Nov 2013 at 10:14

GoogleCodeExporter commented 9 years ago
The Cyanogen is o fork of the original android, that permit at the user to 
choose the number of point , and it working pretty well.
I just download the code to understand the difference . (almost 1G of source 
code)

You have right, the difference  is in the class 
https://github.com/CyanogenMod/android_frameworks_base/blob/cm-10.2/core/java/co
m/android/internal/widget/LockPatternView.java 

The class Cell (line 147) was the key of this feature
 public static class Cell {
...
 static Cell[][] sCells;
        static {
            updateSize(LockPatternUtils.PATTERN_SIZE_DEFAULT);
        }

Replace the Cell class with the cyanogen could permit to do it. 
Do known the impact on the code, like password model persistence ?

Original comment by jmori...@gmail.com on 16 Nov 2013 at 11:54

GoogleCodeExporter commented 9 years ago
I'm sorry, could you be more clear? I don't get the question...

Original comment by haibison...@gmail.com on 16 Nov 2013 at 8:53

GoogleCodeExporter commented 9 years ago
Since the author hasn't participated in this issue for a while, we're closing 
it.

Original comment by haibison...@gmail.com on 17 Jan 2014 at 3:18