Possible interaction with content below in dialog mode

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Opening lock pattern activity with Dialog style
2. It's possible to click content below the dialog
3. "Dialog" is not dismissing when clicking outside it

What is the expected output? What do you see instead?
"Dialog" should dismiss on click outside it's main content. Also it shouldn't 
be possible to interact with the content below.

Original issue reported on code.google.com by jacek.kw...@gmail.com on 11 Apr 2014 at 10:08

[GoogleCodeExporter]

Hi,

Thanks for your report.

I'll take time to fix issue #3 soon. About #2, would you please explain more? 
Do you mean "behind" or "below"? (I'm sorry my English is not good.)

Original comment by haibison...@gmail.com on 11 Apr 2014 at 10:12

• Changed state: Accepted
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Sure, check this out:

https://www.evernote.com/shard/s361/sh/2e2ac638-87f4-45d8-bea1-cbe5cf4c03ef/d824
c36919abf729033f2bb3574db6c3

Original comment by jacek.kw...@gmail.com on 11 Apr 2014 at 10:19

[GoogleCodeExporter]

Thanks, although it looks weird  :-D

Hai,

Original comment by haibison...@gmail.com on 11 Apr 2014 at 10:27

[GoogleCodeExporter]

Well, yeah I redesigned it a bit, but it will work the same on default style

Original comment by jacek.kw...@gmail.com on 11 Apr 2014 at 10:28

[GoogleCodeExporter]

Sorry for rushing but, how do you think, when will there be fix ready?

Original comment by jacek.kw...@gmail.com on 11 Apr 2014 at 12:35

[GoogleCodeExporter]

Oh please feel free to ask any questions. If we can help, we help  :-)  That is 
the purpose of this Issues section.

The bug #3 is easy to fix. But when I said "weird", I didn't refer to your 
design -- btw, very nice :-) -- but the bug #2. I meant normally the user can't 
touch the controls staying behind a dialog. It's impossible for me to reproduce 
that issue, as the demo app works well on my device (Acer Liquid Mini E310, 
running Android 2.3.5). I don't have other devices  :-(

I'm working here with other projects (as a freelancer). I'll try to fix #3 this 
weekend, or even just next some hours if I can.

About #2, I'm very sorry I can't estimate the time frame, at least at this 
moment  :-(

Original comment by haibison...@gmail.com on 11 Apr 2014 at 12:43

[GoogleCodeExporter]

Thanks for such answer!

I'll try to test out not-modified library later and confirm if this is library 
bug or I just broke something during customizations.

Original comment by jacek.kw...@gmail.com on 11 Apr 2014 at 1:22

[GoogleCodeExporter]

Hi,

I've fixed #3. Please see this commit r064c1a8e0ec0f28849f589f7c832586031a652fd 
(https://code.google.com/p/android-lockpattern/source/detail?r=064c1a8e0ec0f2884
9f589f7c832586031a652fd).

You can just copy/paste this overridden method:

    public boolean onTouchEvent(MotionEvent event)

into your current LockPatternActivity. I tested on tablet emulator API 10.

Original comment by haibison...@gmail.com on 11 Apr 2014 at 9:25

[GoogleCodeExporter]

The problem actually was because I inherited LockPatternActivity from my 
CustomActivity (which inherits Activity). Any idea why this might be a problem?

Also - can I somehow change width or height of  the dialog area?

Original comment by jacek.kw...@gmail.com on 14 Apr 2014 at 8:09

[GoogleCodeExporter]

I guess it might be the resources.

I have some suggestions:

- Please try the demo first, if it won't raise the issues, then they come from 
your original CustomActivity.

- Could you try your CustomActivity in dialog mode, and test if the user can 
touch the controls behind it?

Dialog in small and normal screens uses 100% width and 100 % height. The border 
around the dialog is actually the content of the dialog itself, but it's 
transparent. For large, x-large, there are variants. You can open this file and 
change the internal values of the enum ScreenSize:

    com.haibison.android.lockpattern.util.UI

where .6f is 60%, .9f is 90%, .7f is 70%... They are copied from AOSP. But in 
AOSP, they're located at resources (.XML files). I move them to that enum for 
more convenient.

Original comment by haibison...@gmail.com on 14 Apr 2014 at 8:20

[GoogleCodeExporter]

The author hasn't participated in this issue anymore. So we're closing it.

Please feel free to post new message if you want to re-open this issue.

Sincerely,
Hai

Original comment by haibison...@gmail.com on 15 Oct 2014 at 3:01

• Changed state: Done
• Added labels: Type-Other
• Removed labels: Type-Defect