[FR]: Code Quality Gates

hopeman15 commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the problem

While putting together a POC for potential asset handling (#13), I noticed we don't have any linting other than the standard android, or any static analysis tools.

Describe the solution

It would be great to align on the quality gates we want to use so as not to have tons of formatting/linting/etc. changes later.

Additional context

I like to use:

detekt for static code analysis
kotlinter for linting

Code of Conduct

[X] I agree to follow this project's Code of Conduct

tamzi commented 1 year ago

@hopeman15 plan is to create a shared build logic file that creates conventions: As a nice tip to it:

Even have naming conventions and throw it as an error.

see #16

tamzi commented 1 year ago

This can also exist separately for now 👟

hopeman15 commented 1 year ago

@tamzi If we prioritize #16 then no need we could potentially ditch this one, or make #16 a milestone and put this under it 🤔

droidconKE / chai