search

droidconKE / droidconKE2019App

Android app for the second Android Developer conference-droidcon in Nairobi 2019
https://appetize.io/app/wavc552uqmn76jaz7bd2bf890r
MIT License
16 stars 15 forks source link

Code Improvements #73

Open wangerekaharun opened 4 years ago

wangerekaharun commented 4 years ago

After reading this Pokedex Review. I felt there are a couple of points on lifecycle and architecture components that we would borrow from them.

michaelbukachi commented 4 years ago

I can't believe I never knew about viewLifecycleOwner till today. We should definitely try to improve the code where we can.

michaelbukachi commented 4 years ago

But we should also take note of that some of the problems highlighted are already solved using kotlin goodness and DI.

wangerekaharun commented 4 years ago

I can't believe I never knew about viewLifecycleOwner till today. We should definitely try to improve the code where we can.

Also knew with that article. Yes am working on it.

wangerekaharun commented 4 years ago

@michaelbukachi Done with all the suggestions from the article and code improvements. You can also have a look at areas where you can also improve.

michaelbukachi commented 4 years ago

Awesome. Let me take a look.