droidconKE / droidconKE2020App

Android app fully written in Kotlin for droidconKE2020

120 stars 42 forks source link

feat: Add endpoint for fetching sponsors #165

Closed michaelbukachi closed 4 years ago

michaelbukachi commented 4 years ago

What is the Purpose?

Add endpoint integration for fetching sponsors

What was the approach?

Set up API service

Are there any concerns to addressed further before or after merging this PR?

State some additional info if any. For instance running install or setting some environment variable(s)

Mentions?

@wangerekaharun

Issue(s) affected?

146

wangerekaharun commented 4 years ago

Implement Fetch Sponsors

michaelbukachi commented 4 years ago

Everything looks fine.

I have a quick question, how will having a interface for each endpoint scale with the other endpoints in mind too @michaelbukachi

We can add other interfaces and register them with Retrofit. I tried to group the even endpoints together.

wangerekaharun commented 4 years ago

Everything looks fine. I have a quick question, how will having a interface for each endpoint scale with the other endpoints in mind too @michaelbukachi

We can add other interfaces and register them with Retrofit. I tried to group the even endpoints together.

So ideally an interface for each group, what are the downsides of having endpoints defined on one interface?

michaelbukachi commented 4 years ago

There really is no advantage/disadvantage. besides aesthetics. We could put all endpoints in one interface and just group them by comments.

wangerekaharun commented 4 years ago

There really is no advantage/disadvantage. besides aesthetics. We could put all endpoints in one interface and just group them by comments.

Alright, got it, going ahead to merge this