droidconKE / droidconKE2020App

Android app fully written in Kotlin for droidconKE2020
121 stars 42 forks source link

Auto-hide bottom navigation view #176

Closed muth0mi closed 3 years ago

muth0mi commented 3 years ago

What is the Purpose?

This PR seems to auto hide the bottom navigation view when scrolling downwards and showing it while scrolling upwards to increase screen estate for the content and to avoid dirty paddings

What was the approach?

  1. Add a HideBottomViewOnScrollBehavior flag to the bottom nav bar
  2. Remove paddings set in the other fragments

Are there any concerns to addressed further before or after merging this PR?

No

Mentions?

@wangerekaharun @michaelbukachi

Issue(s) affected?

closes #174

muth0mi commented 3 years ago

Nicely done. @wangerekaharun we need a ticket to address the kotlin synthetics

We could go databinding all the way.

michaelbukachi commented 3 years ago

Nicely done. @wangerekaharun we need a ticket to address the kotlin synthetics

We could go databinding all the way.

Agreed :ok_hand:

muth0mi commented 3 years ago

Nicely done. @wangerekaharun we need a ticket to address the kotlin synthetics

We could go databinding all the way.

Agreed

I've created an issue (#177 )

wangerekaharun commented 3 years ago

Nicely done. @wangerekaharun we need a ticket to address the kotlin synthetics

I thought we started well with viewBinding

wangerekaharun commented 3 years ago

Auto hide btm nav

wangerekaharun commented 3 years ago

Auto-hide bottom navigation bar on scroll up and show on scroll up