Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This PR accomplishes the following:
extract the sponsors section code into a reusable DroidconSponsors component, thus preventing code duplication.
structure the component to receive api data
Sample API data used
{
"data": [
{
"name": "JetBrains",
"tagline": "Essential tools for software developers and teams",
"link": "https://www.jetbrains.com/",
"sponsor_type": "silver",
"logo": "https://download.logo.wine/logo/JetBrains/JetBrains-Logo.wine.png",
"created_at": "2022-10-17 13:37:26"
}
]
}
The component is used by the following files:
HomeScreenNotLoggedIn.tsx
HomeScreen.tsx
In line with the design, I have enhanced some form of visual hierarchy for displaying sponsors logos based on their sponsor_type property as follows:
sponser_type
Max number of sponsers per row
platinum
1
gold
2
silver
3
bronze
4
HomeScreen Screenshots
Logged Out
Logged In
Fixes #56
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
[x] Running locally using android emulator and an android device running on android 9
[ ] Test B
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This PR accomplishes the following:
DroidconSponsors
component, thus preventing code duplication.The component is used by the following files:
In line with the design, I have enhanced some form of visual hierarchy for displaying sponsors logos based on their
sponsor_type
property as follows:sponser_type
HomeScreen Screenshots
Logged Out
Logged In
Fixes #56
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: