search

droidconKE / flutterconKEApp

https://play.google.com/store/apps/details?id=dev.flutterconke.app
14 stars 25 forks source link

feat: add social media sharing #91

Closed DanroyMwangi closed 3 months ago

DanroyMwangi commented 3 months ago

Description

This PR:

Closes #61 Closes #88

Areas for Future Improvement

Error Handling: Currently, errors for missing social media apps are displayed in the terminal. Consider enhancing the user experience by showing these errors directly in the UI. Screenshot from 2024-08-16 23-11-08

Type of Change

Test on Device

You can download the APK from Firebase App Distribution once this PR builds successfully via the following link: Download APK

Look

MillerAdulu commented 3 months ago

@DanroyMwangi,

Quite a number of formatting and lining issues, do ensure to run the fmt command in the Makefile once you are done so that the pipeline check is passed.

MillerAdulu commented 3 months ago

Overall, great approach to solving the issue. We should be able to finalize after these minor changes.

DanroyMwangi commented 3 months ago

Please share if there are any iOS-specific steps that need to be applied so that I can have them noted down. This app currently runs smoothly on both platforms.

I made changes for the Android platform based on the Appinio Social Share documentation. Unfortunately, I was unable to test these changes on iOS.

MillerAdulu commented 3 months ago

Please share if there are any iOS-specific steps that need to be applied so that I can have them noted down. This app currently runs smoothly on both platforms.

I made changes for the Android platform based on the Appinio Social Share documentation. Unfortunately, I was unable to test these changes on iOS.

What particular changes were made for iOS to allow me to test them on my end? Just the exact lines that need changing since we don't support all the platforms listed there.

MillerAdulu commented 3 months ago

@DanroyMwangi

Do you have a time estimate for this. Needing to assign another issue that's dependent on this being merged to avoid unpleasant merge conflicts.

DanroyMwangi commented 3 months ago

@DanroyMwangi

Do you have a time estimate for this. Needing to assign another issue that's dependent on this being merged to avoid unpleasant merge conflicts.

Hey, I’m currently a bit tied up. The earliest I can deliver this is by this evening. I appreciate your patience!

MillerAdulu commented 3 months ago

Made a new issue #94 to enable Facebook sharing to happen on iOS and Android. Will finalize the pending Facebook work on that issue to allow work to move on. Thank you for your contribution merged via #93