Closed HenriDellal closed 3 years ago
I have yet to test this, but generally looks ok to me. Does it work on your device?
Plus, this is my personal opinion - and you should wait for feedback from @erikinkinen - but backslashes are very un-pythonic and should not be abused. Please use implied line continuation when possible. Python's own PEP8 style guide might be a good inspiration.
I would also like for commits to be more descriptive, "Refactoring" is not really useful when looking through the repository history. "Styling and line-length changes" looks better for this specific case, in my opinion.
Thanks.
I have yet to test this, but generally looks ok to me. Does it work on your device?
I don't have any device to test this on.
Plus, this is my personal opinion - and you should wait for feedback from @erikinkinen - but backslashes are very un-pythonic and should not be abused. Please use implied line continuation when possible.
I'll make changes as requested.
I would also like for commits to be more descriptive
Will do that as well.
Looks good to me. I think this could be merged after squashing the refactoring commits.
Closing as there is no activity.
Needs review and testing