search

droidian / oFono2MM

Python daemom implementing ModemManager D-Bus API and using oFono to manage the modems.
BSD 3-Clause "New" or "Revised" License
8 stars 8 forks source link

Allow using with ofono phonesim #20

Closed jbruechert closed 3 months ago

jbruechert commented 4 months ago

This makes it possible to use ofono-phonesim for testing ModemManager applications

FakeShell commented 4 months ago

i think instead of just allowing certain modems it would be best to try make it work with all modems testing with a quectel modem i also had to add something here but not ideal really

jbruechert commented 4 months ago

What was the intention behind this check initially?

FakeShell commented 4 months ago

it was added here https://github.com/droidian/oFono2MM/commit/46cc92a6b41a7f33dc352b679d2120c1ae37b384 maybe @g7 can give us some insights

erikinkinen commented 4 months ago

it was added here 46cc92a maybe @g7 can give us some insights

The reason it was added initially was that oFono exported some non-existent modems on the bus for a short time and oFono would not respond to any queries on those modem which would hang oFono2MM. The fun part is that it only seems to occur on some devices. I have none such devices, but it did occur on some of Eugenio's devices iirc.

erikinkinen commented 4 months ago

And I agree that it would be better to actually fix the root cause of the problem and allow any modems to be used with oFono2MM.

g7 commented 4 months ago

yes, 100% agreed on what @erikinkinen said. This needs to be properly fixed, but in the mean time it is more than acceptable imho to merge this.