search

droidstealth / droid-stealth

THIS PROJECT IS DEPRECATED
GNU General Public License v2.0
61 stars 22 forks source link

Adaptive action icons #130

Closed OlivierHokke closed 10 years ago

OlivierHokke commented 10 years ago

Icons are now adaptive to the content that is currently selected. Ordering of icons is prioritized on security and file safety. "Lock" is always first if possible, then "Unlock", then "Share", "Open", "Export", and finally "Destroy".

Closes #129. Closes #77.

OlivierHokke commented 10 years ago

Although I think that "open" should come before "share". Note: one can also share those files after opening them in another application. Edit: I am also not so happy with the "open" color. Edit2: the icons don't adapt yet when a selected file changes in state (locked/unlocked/processing), while being selected

alexwalterbos commented 10 years ago

The open icon is barely readable on my phone due to the color scheme. Also, the magnifying glass is generally associated with search, isn't it? I don't have a good suggestion otherwise though. The icon ordering is good :+1:

Reviewing code now. Code looks good, please use the formatter where mentioned and it's good to go. I was wondering why the icon has been added twice, in separate folders?

OlivierHokke commented 10 years ago

Icon is once in the source folder as it exports there. Second is in the source folder for the app.

Will change open icon, will fix the no-update bug with status changing files, will reformat.

OlivierHokke commented 10 years ago

Ready for another review. and hopefully merge

OlivierHokke commented 10 years ago

It started to be random, therefore #136

alexwalterbos commented 10 years ago

<3 merging this sucker.