search

droidstealth / droid-stealth

THIS PROJECT IS DEPRECATED
GNU General Public License v2.0
61 stars 22 forks source link

Tap to lock crash & persistent selections #144

Closed OlivierHokke closed 10 years ago

OlivierHokke commented 10 years ago

There was still a problem with the tap to lock, as it assumed the fileindex existed. Had to do quite some refactoring to get everything working smoothly. Fixed one other bug along the way where the app couldn't boot up because the random cache file generator created a file with an empty filename.

So this common bug is fixed: java.io.FileNotFoundException: /data/data/com.stealth.android/cache: open failed: EISDIR (Is a directory

Closes #142. Closes #131.

OlivierHokke commented 10 years ago

Should be ready

jzvandenoever commented 10 years ago

When loading the app with a large amount of photos it just loads the green locked square until something gets selected. Does not happen in master.

jzvandenoever commented 10 years ago

Hmm... weird. Now I can't replicate it any more.

OlivierHokke commented 10 years ago

I will not look into that right now, because it is not a crashing bug and thus it does not have priority. But it is good you created the issue #146

OlivierHokke commented 10 years ago

Moved PR #132 this to this as the changes here made that PR obsolete and it was dependent upon this PR anyway. Made the appropriate changes for issue #131 in commit 2daec3d.

Updated title and first comment accordingly

jzvandenoever commented 10 years ago

I can't make it break aside from the weird issue I have occasionally. But that happens in other branches too.