Created launch settings tab

droidstealth / droid-stealth

THIS PROJECT IS DEPRECATED

GNU General Public License v2.0

61 stars 22 forks source link

Created launch settings tab #161

Closed OlivierHokke closed 10 years ago

OlivierHokke commented 10 years ago

Created the launch settings page (with descriptions)
Created the launch managers (already in earlier commit)
Connected the functionalities
Dialer now uses launch code and checks if the method is enabled
App hiding is only done if another launch method was picked
Widget is hidden from widget list if it is not enabled
Widget can be temporarily shown on the home screen using the settings
Refactored the VisibilityManager to account for hiding the widget
the launch settings page checks whether we could indeed disable the app icon

Closes #160

OlivierHokke commented 10 years ago

Created issue #162 for improving English texts

OlivierHokke commented 10 years ago

Also, the hidden state of the widget is not actually hidden: it is a super transparent white. Will change to full invisibility soon.

OlivierHokke commented 10 years ago

Working on something small still: widgets should show when adding a new one, otherwise you don't know where it is and you can't move it :P

OlivierHokke commented 10 years ago

should be ready now

alexwalterbos commented 10 years ago

Also, the hidden state of the widget is not actually hidden: it is a super transparent white. Will change to full invisibility soon.

What widget?

OlivierHokke commented 10 years ago

Well, for now I created the invisible one as yours wasn't ready. Hopefully they can co-exist? :+1:

alexwalterbos commented 10 years ago

Of course.

First things first: ~~I cannot open the app with the widget, nor with dialing in this branch; both on my phone and my tablet.~~ Funny thing: If you don't change the settings on the first try, you cannot open the app ever again. I was unable to because I wanted to test the widget before enabling the widget launch, and I didn't enable the dialer launch yet either. Had no access until reinstalling!

Regarding the launch settings tab: I think there is way too much text. This is hardly a settings menu, it's more of a story about settings :wink: I think we should just try to use a 'standard' settings app, with a number of settings in there, and an explanation shown on press.

OlivierHokke commented 10 years ago

did you try to find the icon? that should have been enabled by default. The dialer and widget are disabled by default.

Also, yes, too much text, I agree, therefore #162, but for now I will leave it like that if you don't mind.

Also, I disagree with the 'standard' settings app, because A I can't use settings fragments for the API that we want to support and B this works perfectly in my opinion, except that the texts are too long, and they could perhaps use some collapsing toggle. Not gonna do that now, though. Feel free to make an issue for it.

alexwalterbos commented 10 years ago

I'll have a look at the texts, I think I'll be able to shorten them. The issue however is that I don't think the explanations should be shown every time the user opens this tab. After the first or second time, the user will know, and I think we could better hide the explanations behind a button to press for explanations.

OlivierHokke commented 10 years ago

and they could perhaps use some collapsing toggle

Ok so we agree on this. Would you like to create it?

alexwalterbos commented 10 years ago

Ah sorry, read over that. I'll look into it. #166

alexwalterbos commented 10 years ago

Will do shorter and collapsable texts in another pull request.