search

droidstealth / droid-stealth

THIS PROJECT IS DEPRECATED
GNU General Public License v2.0
61 stars 22 forks source link

report editing pass #243

Closed jzvandenoever closed 9 years ago

jzvandenoever commented 9 years ago

Just some things I noticed and changed while reading. Not yet finished.

jzvandenoever commented 9 years ago

@OlivierHokke mentioning you here since this applies to your work. There's more comments in the file itself. But this is my general impression while reading.

Hey went through the remainder of the approach and design stuff. But right now the section feels a little disjointed. It's not entirely clear to me what the section is supposed to explain to me as a reader.

The individual parts are nice. Maybe the sequence of subsections and subsubsections needs some reworking. And the styling subsubsection of user experience might need a few references to substantiate the claims made there on the effects of our visual style choices if we are going to say that.

AlexKolpa commented 9 years ago

Sorry, but I'm against merging these fixes. They touch everything, and I feel there are still way too many issues with them. I'd prefer to refractor first and do small fixes later. Keeping this open will take way too long, since it basically touches everything. :-1: from me.

AlexKolpa commented 9 years ago

Closing this for now in favor of refractoring the report structure first and splitting this up into smaller segments afterwards.