droidstealth / droid-stealth

THIS PROJECT IS DEPRECATED
GNU General Public License v2.0
61 stars 22 forks source link

Create the basics for the navigation drawer. #91

Closed OlivierHokke closed 10 years ago

OlivierHokke commented 10 years ago

Give it a nice design to fit our current style. To be added to this drawer:

OlivierHokke commented 10 years ago

Anything to add, or change, or remove? @AlexKolpa @AlexWalterbos @jzvandenoever This list is not meant to be the final list of things the app HAS TO contain. It just is a list of what it could have and hopefully will. Perhaps we should define our priorities in this list as well.

alexwalterbos commented 10 years ago

What exactly do you mean by the navigation drawer? Sorry if it's supposed to be obvious, I'm not too good with naming UI components. Based on that I can respond to the points in the description.

OlivierHokke commented 10 years ago

The navigation drawer is that thing that you can slide in, by swiping with you finger from the left edge of the screen to the right. It's supposed to navigate you through the app Sent using CloudMagic On Thu, Apr 03, 2014 at 10:11 PM, Alex Walterbos notifications@github.com wrote:What exactly do you mean by the navigation drawer? Sorry if it's supposed to be obvious, I'm not too good with naming UI components. Based on that I can respond to the points in the description.

—Reply to this email directly or view it on GitHub.

alexwalterbos commented 10 years ago

Ah.

Sorry, the rest will come later as an edit

jzvandenoever commented 10 years ago

It's the google name for that component.

I agree with Alex on the above.

I do wonder if we want the pin changer so prominently in the app. Maybe it should be part of the settings tab instead? Because it can't easily be done by accident then?

Why have a morphing tab? Why not just have that be part of the app sharing option?

And I still wonder what the value is for ordinary users to have that output tab. So not sure if it should be in there.

alexwalterbos commented 10 years ago

I agree with Joris again on his additions. The morphing tab is 'useless' after installation right? You can't morph the app at that point anymore, so indeed the only logical place for that logic is when sharing or receiving the app.

I think the output folder is something that will not be of any use to a non-developer, since we have notifications and toasts to give the essential output.

As for the clearing sms, call log, and whatnot; I think we should focus on the simplicity of the app, the core functionality: hiding files. Clearing the other stuff can be an addition later, but that surpasses the vision of the app for now, I think.

OlivierHokke commented 10 years ago

Pin changer can't really be by accident, because I guess you need to fill in the old one? It could include the option to turn on the fake pin too and since I already created the pin fragment, it would be easier to create a tab for it for now.

Clearing privacy sensitive data is no must, I agree. But I do think it brings an important addition that gives our app an advantage over others, as our app is then mainly focused on keeping things private.

We thought of morphing in order to morph your own installation: by creating a morphed APK you can update your own by running it and installing. Therefore: not only sharing. But starting with an SPK share should also start a morph fragment, so I can reuse it.

Output log is not per se necessary, but it could give extra information to the user as to what is happening. For instance if the user added a file, we don't want to bloat him with messages in the bottom bar, but we just say "File added successfuly". However in the output page it could show extras next to "File added successfuly", such as "Removed original file from device successfully", to give the user more feedback on what we do and to create a little more trust. It is just an idea, but I think it would be interesting. Obviously, since it isn't a very important "feature" it wouldn't be shown as one, it would be at the bottom of the drawer, perhaps under the version number line and less visible, say half opacity.

Yes I thought about a simple single line too for the version number

alexwalterbos commented 10 years ago

Indeed, change pin would require the current pin to confirm to be secure.

I'd say we create an issue for the clearing of caches, text messages, and so on, and tag mr Pouwelse there for his opinion.

I was not aware of that morphing step after installation, if we do decide for that then this is a good place for that functionality. Since you can reuse the fragment I think this is not really a 'biggie', right?

I see you thought of something else when considering an 'output log'. I was thinking about what we see in logcat, except filtered a bit tighter.

Good, we'll add the version number line then.

OlivierHokke commented 10 years ago

I changed my original post on this issue to account for the discussion @ #113. The conclusion might cause another change in this post.