search

drolbr / Overpass-API

A database engine to query the OpenStreetMap data.
http://overpass-api.de
GNU Affero General Public License v3.0
692 stars 90 forks source link

0.7.57 unit test: new make_area_2 test failure #641

Closed mmd-osm closed 2 years ago

mmd-osm commented 2 years ago

I'm getting some unit test failures for make_area_2, which appear to be newly introduced in 0.7.57.

Testing on a837eea7390902aa5026c1fb5e3cf0b089c62256:

13:12:07 Test make_area 1 succeeded.
Files ../../expected/make_area_2/stdout.log and stdout.log differ
13:12:07 Test make_area 2 FAILED.
13:12:07 Test make_area 3 succeeded.
13:12:07 Test make_area 4 succeeded.
13:12:07

It seems the expected and actual stdout.log disagree on whether way 142 should be included in the result:

diff -y stdout.log ../../expected/make_area_2

  <way id="142">                                              <
    <nd ref="1413"/>                                          <
    <nd ref="1415"/>                                          <
    <nd ref="1417"/>                                          <
    <nd ref="1419"/>                                          <
    <nd ref="1420"/>                                          <
    <nd ref="1418"/>                                          <
    <nd ref="1416"/>                                          <
    <nd ref="1414"/>                                          <
    <nd ref="1413"/>                                          <
    <tag k="scale" v="0.0001000"/>                            <
    <tag k="shapes" v="2"/>                                   <
  </way>                                                      <
  <area id="2400000142">                                          <area id="2400000142">
    <tag k="scale" v="0.0001000"/>                                  <tag k="scale" v="0.0001000"/>
    <tag k="shapes" v="2"/>                                         <tag k="shapes" v="2"/>
  </area>                                                         </area>
 0 0 0 0 0 0                                                     0 0 0 0 0 0
 0 1 1 1 1 0                                                     0 1 1 1 1 0
 0 1 1 1 1 0                                                     0 1 1 1 1 0
 0 0 0 0 0 0                                                     0 0 0 0 0 0

Tests were executed using ../src/test-bin/run_testsuite.sh 200 notimes

drolbr commented 2 years ago

The way 142 should be indeed in the result. Fixed in 74a55df15f2ef6b6d1cf1ed0266735d3dd477327 .