search

drolbr / Overpass-API

A database engine to query the OpenStreetMap data.
http://overpass-api.de
GNU Affero General Public License v3.0
692 stars 90 forks source link

Update geometry.cc #649

Closed puffetto closed 2 years ago

puffetto commented 2 years ago

Fixes issue @ #648 I digged a bit into the code: it was an obvious typo (misplaced parenthesis). Cheers, A.

mmd-osm commented 2 years ago

Yes, it's a bug, fix in https://github.com/mmd-osm/Overpass-API/commit/e0963298c09991bb57740069ea45df37b399fdcb never made it upstream.

Impact is low, RHR_Polygon_Area_Oracle isn't used anywhere, so it's basically fixing dead code.

puffetto commented 2 years ago

Yes, it's a bug, fix in mmd-osm@e096329 never made it upstream.

... so it's basically fixing dead code.

Well, for paranoids like me who recompile everything on their machine with -Wall -Werror... is fixing a blocking issue ;)

(The one and only warning here, by the way: chapeau).

Thanks,

A.

mmd-osm commented 2 years ago

This has been fixed somewhere in https://github.com/drolbr/Overpass-API/commit/fad55788c5243dbd01f4f1c56642b9f4ffe8f4c9