drom / LEB128

Little Endian Base 128 converters
MIT License
8 stars 3 forks source link

Get length of bytes & fixed bug on unpacking #2

Closed piranna closed 7 years ago

piranna commented 7 years ago

The bug was about not considering the case of numbers stored on a single byte, we definitely need to add more tests cases. I understand your point of using verilator to build some Node.js bindings and doing the tests in Node.js, is a cool idea, but by the moment using the Makefile is just enought. I would be cool if you start a Verilog binding framework project, but I would do as an independent one.

The length of the bytes is needed to know exactly how much data I inserted. I put it as an aditional parameter, but since is a somewhat independent, don't know if I should put it on its own isolated module to don't waste transistors... what do you think?

By the way, it's getting a bit complicated to convert the code to use generate, that's a shame... :-( Do you have more knowledges about Verilog?