dromara / carbon

A simple, semantic and developer-friendly golang package for time.
https://pkg.go.dev/github.com/dromara/carbon/v2
MIT License
4.83k stars 242 forks source link

Add VietNam lunar calendar #214

Closed culy247 closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (973d8b6) 100.00% compared to head (4372f35) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #214 +/- ## ========================================== Coverage 100.00% 100.00% ========================================== Files 22 23 +1 Lines 2965 3502 +537 ========================================== + Hits 2965 3502 +537 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

culy247 commented 10 months ago

@gouguoyin Review pr for me

gouguoyin commented 10 months ago

I am planning to reconstruct the calendar. Each calendar is an independent package.so not accept PR until the specific plan is finalized.

culy247 commented 10 months ago

I am planning to reconstruct the calendar. Each calendar is an independent package.so not accept PR until the specific plan is finalized.

@gouguoyin Thank you, you can shame me your plan?

gouguoyin commented 10 months ago

It's not finalized yet, do you have any good ideas?

carbon.CreateFromCalendar(c Calendar)
carbon.ToCalendar(c Calendar)
image
gouguoyin commented 10 months ago

You can refer to the latest Chinese Lunar to contribute VietNam lunar calendar,must include CreateFromSolar and CreateFromVLunar methods

culy247 commented 10 months ago

You can refer to the latest Chinese Lunar to contribute VietNam lunar calendar,must include ToGregorian and ToVLunar methods

thank you.