Closed culy247 closed 10 months ago
@gouguoyin Review pr for me
I am planning to reconstruct the calendar. Each calendar is an independent package.so not accept PR until the specific plan is finalized.
I am planning to reconstruct the calendar. Each calendar is an independent package.so not accept PR until the specific plan is finalized.
@gouguoyin Thank you, you can shame me your plan?
It's not finalized yet, do you have any good ideas?
carbon.CreateFromCalendar(c Calendar)
carbon.ToCalendar(c Calendar)
You can refer to the latest Chinese Lunar to contribute VietNam lunar
calendar,must include CreateFromSolar
and CreateFromVLunar
methods
You can refer to the latest Chinese Lunar to contribute
VietNam lunar
calendar,must includeToGregorian
andToVLunar
methods
thank you.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #214 +/- ## ========================================== Coverage 100.00% 100.00% ========================================== Files 22 23 +1 Lines 2965 3502 +537 ========================================== + Hits 2965 3502 +537 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.