Wrong zodiac sign - Githubissues

dromara / carbon

A simple, semantic and developer-friendly golang package for time

https://pkg.go.dev/github.com/golang-module/carbon/v2

MIT License

4.77k stars 238 forks source link

Wrong zodiac sign #216

Closed fishjar closed 9 months ago

fishjar commented 9 months ago

Hello,

I encountered an issue with the following code:

    s := "2024-02-04 13:14:15"
    fmt.Printf("%s IsDragonYear? %v\n", s, carbon.Parse(s).Lunar().IsDragonYear())

I expected to get:

2024-02-04 13:14:15 IsDragonYear? true

But I actually get:

2024-02-04 13:14:15 IsDragonYear? false

Thanks!

fishjar commented 9 months ago

是我搞错了，依据《农历的编算和颁行》GB/T 33661-2017：

农历正月初一为生肖和干支年转换日

Issues-translate-bot commented 9 months ago

The issue body's language is not English, translate it automatically, please use English next time. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

I made a mistake. According to "Compilation and Promulgation of the Lunar Calendar" GB/T 33661-2017:

The first day of the first month of the lunar calendar is the day of conversion between the zodiac signs and the year of the zodiac signs.